An nfo's customrating is unread, and an nfo rating is not traced through the remote merge #244
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found reviewing #240.
<mpaa>is read as the official rating since40ae7be2. Upstream'sBaseNfoParseralso reads<customrating>intoCustomRating, which takes precedence in the parental score. The port's scanWritehas no custom-rating field and the scan never writes that column, so supporting it means a field onWriteand the write path (crates/ephyra-db/src/scan/row.rs), which currently keeps whatever custom rating the row already stores.Not checked: that an nfo-supplied official rating survives the remote-metadata merge in
crates/ephyra-app/src/metadata/mod.rs(take!(official_rating)) the way upstream's provider order leaves it.No fixture nfo under
reference/var/mediacarries either element, so neither is measured against the reference.Landed in
0c7280a3,aa4db784,c0d3e95a:<customrating>is read and written through the scan with upstream's merge (MergeBaseItemData: an nfo value replaces the stored one; an absent or empty element, or a deleted nfo, leaves it). The score columns always follow the derivation, so a locked official rating does not hold a score a custom rating moves — the review's finding, with two tests including the capped-account case. An nfo rating survives the remote merge; pinned by a test that fails withouttake!(custom_rating). Not measured against the reference: no fixture nfo carries either element. The owner-to-owned copy is filed separately.