A disc rip is filed with nothing a probe would have said #38

New issue

Closed

opened 2026-08-03 14:40:58 +02:00 by Claude · 1 comment

Claude commented

2026-08-03 14:40:58 +02:00

Collaborator

A film ripped off a disc is one item at the folder holding the rip (#26), and
nothing probes it: what plays it is a directory of streams rather than a file,
so RunTimeTicks, Size, Width, Height, Container, its streams and its
chapters are all left empty.

Upstream reads the rip. MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
picks the playable files out of the directory and probes those:

a DVD: the .vob files of the largest title set, their runtimes summed
a Blu-ray: the largest .m2ts
Size is the sum of what the directory holds (:208-211)

So every rip row will differ from upstream on the whole of what a probe
answers. Nothing here has that shape yet — a probe is one file, and this is a
list of them whose runtimes add up.

Wanted before the work: a rip to measure against. Neither library here has one,
so the first step is making the reference instance serve one and diffing.

A film ripped off a disc is one item at the folder holding the rip (#26), and nothing probes it: what plays it is a directory of streams rather than a file, so `RunTimeTicks`, `Size`, `Width`, `Height`, `Container`, its streams and its chapters are all left empty. Upstream reads the rip. `MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs` picks the playable files out of the directory and probes those: - a DVD: the `.vob` files of the largest title set, their runtimes summed - a Blu-ray: the largest `.m2ts` - `Size` is the sum of what the directory holds (`:208-211`) So every rip row will differ from upstream on the whole of what a probe answers. Nothing here has that shape yet — a probe is one file, and this is a list of them whose runtimes add up. Wanted before the work: a rip to measure against. Neither library here has one, so the first step is making the reference instance serve one and diffing.

Claude referenced this issue

2026-08-03 14:45:41 +02:00

A film split across discs is filed once per disc #26

Claude referenced this issue

2026-08-03 17:22:09 +02:00

A disc rip is offered for playback with no way to play it #41

Claude commented

2026-08-03 17:24:00 +02:00

Author

Collaborator

Fixed for a DVD in the merge of fix/30-hdr10plus; a Blu-ray still reads
nothing.

A rip is probed through the files that play it. The disc's own menu and each
title's menu are not the feature; what is left is grouped by the number each
name ends with, and the groups holding anything big enough to be a title play.
The first of those files answers for what the item is — its streams, its size,
what it is encoded as — and the rest answer only for how much longer it runs.

A part nothing could read leaves the length unknown rather than short, which is
what adding two of them gives when either is missing.

crates/jellyfin-app/src/scan/discs.rs is the port of
GetPrimaryPlaylistVobFiles, with its rules under test: the menus, the size a
title has to be, the grouping, and the disc whose parts are all small.

Not done

A Blu-ray. Which of its streams play it is written in a playlist under
BDMV/PLAYLIST, and upstream reads it with a library of its own. Nothing here
parses one, so a Blu-ray rip is still filed with what its folder alone says.

Reachable now

#41 — a rip is offered for playback and nothing knows how to play one.

Fixed for a DVD in the merge of `fix/30-hdr10plus`; a Blu-ray still reads nothing. A rip is probed through the files that play it. The disc's own menu and each title's menu are not the feature; what is left is grouped by the number each name ends with, and the groups holding anything big enough to be a title play. The first of those files answers for what the item is — its streams, its size, what it is encoded as — and the rest answer only for how much longer it runs. A part nothing could read leaves the length unknown rather than short, which is what adding two of them gives when either is missing. `crates/jellyfin-app/src/scan/discs.rs` is the port of `GetPrimaryPlaylistVobFiles`, with its rules under test: the menus, the size a title has to be, the grouping, and the disc whose parts are all small. ## Not done A Blu-ray. Which of its streams play it is written in a playlist under `BDMV/PLAYLIST`, and upstream reads it with a library of its own. Nothing here parses one, so a Blu-ray rip is still filed with what its folder alone says. ## Reachable now - #41 — a rip is offered for playback and nothing knows how to play one.

Claude closed this issue

2026-08-03 17:24:00 +02:00